Validation Error No Insert

kvarnerexpress

Sep 11 2005, 01:23 PM

im having some trouble with this

PHP Code:

CODE

while ($checking = mysql_fetch_array($check)){
$usr = $checking['loguser'];
$mail = $checking['logemail'];

$error = "";

if ($mail == $email){
$erroremail = "the email address you have chose is already taken";
$error = 1;
}

if ($usr == $user) {
$errorusername = 'the username you have chosen is already taken';
$error = 1;
}
}
if (strlen($user) < '5') {
$usernameerror = 'the username is too short';
$error = 1;
}

if (eregi("^[a-zA-Z0-9_]+@[a-zA-Z0-9\-]+\.[a-zA-Z0-9\-\.]+$]", $email)) {
$emailerror = 'the email address isnt a valid email address';
$error = 1;
}

if (strlen($password) < '9') {
$errorpass = 'the password is too short it must be at least 8 characters';
$error = 1;
}

if ($error == "") {

$pass = md5($password);

mysql_query("INSERT INTO login (loguser, logpass, logname, logsurname, logaddress, logarea, logcounty, logpostcode, logtelephone, logni, logemail, logcompanyid, logaccess)
VALUES ('$user', '$pass', '$name', '$surname', '$address', '$area', '$county', '$postcode', '$telephone', '$ni' '$email', '$companyid', '".$_POST['access']."')") or die (mysql_error());

header("Location: ../index.php");
}

For some reason the script is passing over the $error, if it does pass over $error == "" then it should display why the error has occured, but I cant get it to work :/ any idea, is there any better way to do this validation.

Thanks,kvarnerexpress

Reply

truefusion

Sep 11 2005, 06:16 PM

Maybe replacing this:

CODE

if ($error == "") {

With:

CODE

if ($error == NULL) {

Might help?

Reply

SystemWisdom

Sep 12 2005, 12:27 AM

Try this:

CODE

while ($checking = mysql_fetch_array($check)){
$usr = $checking['loguser'];
$mail = $checking['logemail'];

$error = 0;

if ($mail == $email){
$errormsg = "the email address you have chose is already taken";
$error = 1;
}

if ($usr == $user) {
$errormsg= 'the username you have chosen is already taken';
$error = 1;
}
}
if (strlen($user) < '5') {
$errormsg= 'the username is too short';
$error = 1;
}

if (eregi("^[a-zA-Z0-9_]+@[a-zA-Z0-9\-]+\.[a-zA-Z0-9\-\.]+$]", $email)) {
$errormsg= 'the email address isnt a valid email address';
$error = 1;
}

if (strlen($password) < '9') {
$errormsg= 'the password is too short it must be at least 8 characters';
$error = 1;
}

if ($error) {
echo $errormsg;
}
else {

$pass = md5($password);

mysql_query("INSERT INTO login (loguser, logpass, logname, logsurname, logaddress, logarea, logcounty, logpostcode, logtelephone, logni, logemail, logcompanyid, logaccess)
VALUES ('$user', '$pass', '$name', '$surname', '$address', '$area', '$county', '$postcode', '$telephone', '$ni' '$email', '$companyid', '".$_POST['access']."')") or die (mysql_error());

header("Location: ../index.php");
}

Reply

SystemWisdom

Sep 12 2005, 12:29 AM

Oh, and you're missing a comma in youSQL statement here: '$ni' '$email'

Sry for double post..

Reply

ADD REPLY / Got an Opinion!	a humble request :-)	RAPID SEARCH!	Free Hosting	[X]
Express your Opinions, Thoughts or Contribute your information that might help someone here. Ask your Doubts & Queries to get answers.. "Together, We enlight each other!"	Register FREE for AD-FREE forum, Create your own topics, Ask Questions, track topics, setup subscriptions & notifications and Get a Free Website w/ Email and FTP.		500MB Space No Ads, CPanel, FTP, PHP, MySQL, EMails - 100% FREE