I Just Wrote A Script For A Php Text Editor!

coolcat50

Oct 12 2007, 08:18 PM

Yes, I just wrote out a script for a PHP text editing program. It is very basic but I would like to be able to actually use this and update it. First, I need version 0.7 to be proofread. It will be upgraded to 0.8 after closed beta, 0.9 after open beta, 1.0 when ready.

I would love to have some people help with this project. Right now it is a simple PHP script and HTML form. Here is the current script. I would like it to be proofread.

CODE

<?php

$fileName = "$_REQUEST['name']";
$fHandle = fopen($fileName , 'w') or die("Can't write file.");
$fContent = "$_REQUEST['content']";
fwrite($fHandle , &fContent);
fclose($fHandle);
?>
<form method="post">
<input type="text" name="name" value="Filename" /><br />
<textarea cols="30" rows="50" name="content">
Text
</textarea>
</form>

Suggestions for this will be great and I would like to make this be a pretty big project. I think it can be cool and very useful for the travelling programmer or webmaster. Thank you.

P.S.: I would love to have assistants to help with updating it and testing and all of that. Thank you.

Stenno

Oct 12 2007, 08:54 PM

Ouch, this will get you hacked easily. They create a file x.php and put this in it:

for example:

CODE

<?

$fHandle = fopen($fileName , 'r+');

while (!feof ($handle)) {
$buffer = fgets($handle, 4096);
echo $buffer;
}

?>

They just run their script after they created it and it gives them login info from your database and so on. It's very important to built in a safety check, so you can check their code first before they can run it. They could also create a injection bug on purpose in the script:

CODE

<?

$page = $_GET['page'];
include($page);

?>

Makes them able to include every file on your server, even files that aren't in that specific map. So watch out with it

Make sure only you can run the script, so for instance make a login for it.

coolcat50

Oct 12 2007, 08:57 PM

This is for the public. I guess i could install a member login system. Could you help me out?

Wait, couldn't I just mod the script to only save as .txt files

Such as

CODE

<?php
$fileName="$_REQUEST['fname']" . ".txt";
$fHandle=fopen($fileName , 'w') or die("Can't write file.");
$fContent="$_REQUEST['content']";
fwrite($fHandle,$fContent);
fclose($fHandle);
?>

MotU2510

Oct 20 2007, 06:00 PM

Making it a .txt file only would make it a LOT safer. Other than that it seems fine to me.

If you did add a member login then perhaps you could add the abilty to open and edit already existing files. That would be very useful for someone who needs the ability to store and edit files on the web. I'd recommend adding a maximum file length as well, you wouldn't want someone to make a ridiculously long file which uses up all your webhost space.

coolcat50

Oct 20 2007, 11:16 PM

Yeah good point. Prob about 100kb on a 2.5gig host

pop

Oct 20 2007, 11:22 PM

many scripts like your is availiable for download, so developing this is point less. you need to learn php much more. i download this script and i have it already, why wait for you to develop your script, and that is also bad code if what stenno said is true. learn php first, and you have time to develop project later.

coolcat50

Oct 20 2007, 11:56 PM

Well, I do know PHP fairly well. Look at my card engine. So, don't be making generalizations like that. kk

MiniK

Oct 21 2007, 12:44 AM

I don't understand what the script is or what it does. Could someone expand on "text editor", please?

Fate

Oct 27 2007, 07:59 PM

QUOTE(MiniK @ Oct 21 2007, 12:44 AM)

I don't understand what the script is or what it does. Could someone expand on "text editor", please?

*deleted acronym*

text editor: noun
A program used to.. edit text
Synonym: Notepad

ADD REPLY / Got an Opinion!	a humble request :-)	RAPID SEARCH!	Free Hosting	[X]
Express your Opinions, Thoughts or Contribute more info. to help others. Ask your Doubts & Queries to get answers, So that "Together We can help others!"	Register FREE for AD-FREE forum, Create your own topics, Ask Questions, track topics, setup subscriptions & notifications and Get a Free Website w/ Email and FTP.		500MB Space No Ads, CPanel, FTP, PHP, MySQL, EMails - 100% FREE