wow, I had no clue a script like this even existed XD awesome, i'll probably use it!!!

Reply

Sorry, but I am not understanding the purpose of this script.

I will point some cons:

- People will still be able to hotlink to it - also, this will make usual hotlinking protection useless.

- About the cache thing, no, the browser will not cache the images, thus increasing your
bandwidth use.

- The other point is that it will make creating pages harder (you will have to write a longer address for img src)

- Scripts that rely on user input are EXTREMELY dangerous. For example, due to a huge design flaw
(if you give some ext like 934910841 it won't be concatenated to the file name; allowing a potential
hacker to inject code or see your files).

Now, some coding tips:

- I noticed unexperienced coding standards, especially indentation for the PHP code.

- Usually instead of using several if and elseif you can use switch

- Use $_GET instead of $_REQUEST

- Be careful with your error checking routine; check if the given ext actually exists.

- Instead of naming an ext an using switch/if else, you can use an array; for example:
$exts = array ('jpg', 'gif', 'bmp', 'png', 'tiff')
$exts[0] is jpg, $exts[1] is gif and so on.

- Learn about INTERPOLATION.
Strings using double quotes (") don't need to be concatenated.

- And finally, the most important: NEVER TRUST USER INPUT!!
Always filter it properly

I hope you don't take this as offense, but as constructive criticism.

Reply

To prevent people from taking images by using right-click, just put in a disable right-click script. It comes in useful in some situations but you are never going to be able to totally protect your images. If I really wanted an image, i could just take a screenshot of the site and cut it out

I think its a really handy tool. I do this on my clan site but for the pages. I use a re.php to redirect the link to the correct page to mask what the actual page name is. There are ways around this too but it helps against noobs :\

xJedix

Reply

The script is currently in use on my website. Right click and do view image on the any of the images on the website and (in firefox I know that) you may be surprised

In the browser, when you do view image, the url will be http;//example.com/img.php?fl=IMAGE&type=2 etc. On my example website, you'll see that I edited the variables in the url.

The cache question however I am unsure about.

If you wish to get image protection, here is a small script I will provide for you:

[hr=noshade][/hr]

Place this on whatever php enabled webpage you want to allow images to be displayed (note it maybe a good idea to alter the contents of the variable):



Just before this line:



on img.php add this:



After this line:



add this:



I'm not sure if this works but try it. I doubt though that it will protect right click, save as. What I do think it'll protect is:

1. Image Hotlinking
2. Accessing images directly

When someone hotlinks your image, the nasty red cross will appear when they view your page. If they access the image directly, the alert will appear.

Note: This script has not been tested but I am 99.99% sure it'll work, please make backup copies of your files first.

Reply

what might be good is a page where we can see this scipt in use. i mean does this also prenevnt people for right clicking the image and then pressing View Image? how would that show in the url box in a browser. Maybe it will show diffrently for diffrent browsers. sorry for being so critical but other than that nice script.

Reply