 Need Help With C Program To Test If A Number Is Prime, Ending unexpectedly somewhere near for-loop |
|
|
|
|
  |
 Feb 4 2006, 11:28 PM
Post
#1
|
|
|
Privileged Member  Group: Members Posts: 629 Joined: 26-February 05 Member No.: 3,995  |
CODE #include <stdio.h> main() { printf("Enter a number: "); int n; scanf("%d", &n); if(n == 2) printf("%d is prime", n); else if(n % 2 == 0 || n < 2) printf("%d is not prime", n); else { int x; for(x = 0; x < (int)sqrt((double)n); x++) if(n % x == 0) { printf("%d is not prime", n); return; } printf("%d is prime", n); } } If n is 2, less than 2, or a multiple of 2, then the program runs fine. Otherwise, I get told that it encountered a problem. I'm kind of new to C, so I'm not exactly sure what's wrong. My background is in Java =/ Can anybody see anything that may be causing the problem? |
 |
 
|
|
Feb 4 2006, 11:44 PM
Post
#2
|
|
|
Super Member Group: Members Posts: 276 Joined: 4-August 05 Member No.: 10,273 |
Problem is in this part:
QUOTE(beeseven @ Feb 5 2006, 01:28 AM)  CODE else { int x; for(x = 0; x < (int)sqrt((double)n); x++) if(n % x == 0) { printf("%d is not prime", n); return; } printf("%d is prime", n); } } I can't tell exactly where since I dont have a compiler and time to analyse it now. Tell me what kind of message you get as return error and it might go smoothly.... It's probably somewhere in this for loop. |
|
|
|
|
Feb 5 2006, 12:08 AM
Post
#3
|
|
|
Desperately seeking "any key" to continue...  Group: Admin Posts: 3,467 Joined: 23-April 05 From: Trap17 storage box Member No.: 6,042 |
QUOTE(beeseven @ Feb 4 2006, 06:28 PM) CODE int x; for(x = 0; x < (int)sqrt((double)n); x++) if(n % x == 0) I'm assuming I still remember how C's FOR LOOP works. You are dividing by zero as the first step. Therefore, it does not work. Your initial value of x is zero, and you're doing n % x == 0 which will not execute. And THEN it checks to see x < ...etc and add 1 value to x. But since it tried to divide by zero, this loop will stop to protect your computer from hanging. |
|
|
|
|
Feb 5 2006, 12:30 AM
Post
#4
|
|
|
Privileged Member Group: Members Posts: 629 Joined: 26-February 05 Member No.: 3,995 |
Oh yeah >_< I forgot the first rule of a prime checker: start the loop at 3 and increment by 2.
|
|
|
|
|
Feb 8 2006, 11:32 AM
Post
#5
|
|
|
Desperately seeking "any key" to continue... Group: Admin Posts: 3,467 Joined: 23-April 05 From: Trap17 storage box Member No.: 6,042 |
Since I don't have C or C++ complier anymore, I tried to do my own coding...but failed miserably so I searched the web to find some helpful tips and formulas.
HTML <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=windows-1252"> <title>Prime Number</title> </head> <body> <script LANGUAGE="JavaScript"> <!-- Begin function calculate(form) { var num=parseInt(form.number.value); if (isNaN(num) || num < 0) { form.result.value=(form.number.value + " is not a valid number! Try again!"); } if (num == 1) { form.result.value=("1 is not prime by definition!"); } if (num == 0) { form.result.value=("0 is not a valid number."); } if (num == 2) { form.result.value=("2 is a prime number!"); } for (var i=2;i<num;i++) { if (num % i == 0) { var prime="yes"; form.result.value=(num + " is not prime. It is divisible by " + i + "."); break; } if (num % i != 0) var prime="no"; } if (prime == "no") form.result.value=(num + " is prime!"); } // End --> </SCRIPT> <P align="left"> <div align="left"> <table width="100%" border="0" cellspacing="2" cellpadding="2"> <tr> <td> <div align="left"><font size=6><font size="+2" align=RIGHT color="#0000FF"><font color="#CC6600" size="+1">Prime Number</font></font><br> </font> <table border=0 width=486 cellpadding=3 cellspacing=0> <tr> <td>Enter a number and the Prime Number Calculator will instantly tell you if it is a prime number or not.</td> </tr> </table> </div> <form name=form> <div align="left"> <p>Please enter a number: <input type=text name=number size=10> <br> <input type=button value="Is it prime?" onClick="calculate(this.form)" name="button"> <input type=text name=result size=45 value=""> <br> </p> </div> </form> </td> </tr> <tr> <td>Prime numbers are positive, non-zero numbers that have exactly two factors -- no more, no less.</td> </tr> </table> </div> </body> </html> Try to see if you can use this to reverse engineer your For Loop. |
|
|
|
|
Feb 9 2006, 06:53 AM
Post
#6
|
|
|
Premium Member Group: Members Posts: 165 Joined: 12-September 05 Member No.: 11,777 |
QUOTE(ciroxyz @ Feb 5 2006, 07:44 AM) Problem is in this part: I can't tell exactly where since I dont have a compiler and time to analyse it now. Tell me what kind of message you get as return error and it might go smoothly.... It's probably somewhere in this for loop. int n; int i; int isPrime = 1; //1 is true and 0 is for false, there is no boolean in C not like C++ //it should be set initialy to true for(i=n;i>1;i--) { if(n%i==0) { isPrime = 0;//set to false if n is evenly divisible break; //then exit the loop leaving isPrime == false } } if(isPrime) printf("It is a prime number."); else printf("it is not a prime number."); i think this one will work, but if you already solved the problem it is still useful becuase its a diferent method cmpared to yours.. by the way this code does not work with 2 it only works for 3 and above.. good luck... |
|
|
|
|
Feb 27 2006, 09:59 PM
Post
#7
|
|
|
Super Member Group: Members Posts: 282 Joined: 30-May 05 From: Bangalore Member No.: 7,686 |
@Saga: Your program will take fractionally longer to run, because you loop through all the cases (if I understand correctly), which is not really necessary. Some simple math will tell you that looping through 1 to sqrt(n) is enough to detect if n is prime or not. So you can optimize your program performance. I know this sounds like I'm being picky, but when you're testing if 352224t657723242366667 is a prime or not, it does make a difference
 @beeseven: Providing the exact error message would help - although, for starters, I think I'm missing the opening and closing flower-braces under the for loop. Can you check that up? Other than that, I really don't see why the code shouldn't work... |
|
|
|
|
Feb 28 2006, 01:17 AM
Post
#8
|
|
|
Privileged Member Group: Members Posts: 629 Joined: 26-February 05 Member No.: 3,995 |
It does, I posted that I solved my problem 23 days ago.
|